Fix: Reduce foreground service timeout crash on cold start#451
Merged
Conversation
Calling startMonitor() in App.onCreate() started the foreground service timeout clock before the BroadcastReceiver even ran, consuming timeout budget with post-init work and receiver processing. The service is already started by BluetoothEventReceiver, BootCompletedReceiver, and OverviewViewModel, making this call redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reduced the chance of a crash that could happen when the app starts in the background after a Bluetooth event. The monitoring service could fail to start quickly enough on devices under heavy load, causing a system-level crash.
Technical Context
App.onCreate()calledstartForegroundService()eagerly, starting the system's 10-second foreground timeout clock before the BroadcastReceiver even ran. This meant the timeout window included both the remainder ofApp.onCreate()and the fullBluetoothEventReceiver.onReceive()execution — time the service couldn't use to callstartForeground().BluetoothEventReceiver,BootCompletedReceiver, andOverviewViewModelall independently start the monitoring service when needed.ActiveServices.javathat the system already deduplicates redundantstartForegroundService()calls and skips timeouts for already-foreground services — no app-level deduplication needed.