Fix: Fix crash when Google Play billing service disconnects#446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed a crash that could happen when the Google Play billing service disconnects unexpectedly (e.g., during a Play Store update or when the OS kills the billing process).
Technical Context
BillingClientConnectionProvider's 5 retry attempts are exhausted, theBillingExceptionpropagates toBillingDataRepo.connectionProviderwhich had a.catch { throw it }before.replayingShare(scope). The re-throw causesshareIn's internal coroutine to fail with an unhandled exception in theSupervisorJob-basedAppScope, crashing the app..catch { throw it }with.retryWhenthat retries indefinitely with 60s backoff. This keeps theSharedFlowalive — when the billing service returns, the connection re-establishes automatically.upgradeInfoflow already hasonStartfallback values (grace period), so the UI isn't blocked during retry waits.