Fix: Fix contact form retaining old text after sending#444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed an issue where the "Contact Developer" form would keep the previously entered text when reopening the screen after sending an email.
Technical Context
NavDisplayinMainActivitywas missing theViewModelStoreNavEntryDecorator, sohiltViewModel()scoped all ViewModels to the Activity instead of their navigation entry. When an entry was popped from the back stack, its ViewModel survived and was reused on the next visit.lifecycle-viewmodel-navigation3:2.10.0dependency was already in the project but never wired up — this connects it by addingentryDecoratorstoNavDisplay.