General: Replace Moshi JSON library with built-in serialization#442
Merged
General: Replace Moshi JSON library with built-in serialization#442
Conversation
Remove Moshi dependency entirely, completing the migration to kotlinx.serialization. All JSON serialization now uses kotlinx with explicit @SerialName annotations for wire format stability. - Migrate PodDeviceCache from Moshi to kotlinx Json injection - Add MapIntByteArrayBase64Serializer for BleScanResult cache compat - Strip @JsonClass/@JSON annotations from all dual-annotated classes - Delete Moshi adapters, ProGuard rules, and build config - Convert compat tests to pure kotlinx round-trip tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the Moshi JSON library entirely, completing the migration to the built-in kotlinx.serialization that was already partially in place. No user-facing behavior change — all stored settings, device profiles, and cached data remain readable.
Technical Context
PodDeviceCachewas the only runtime component still using Moshi directly — migrated to the existing@SerializationCapod Jsoninstance.MapIntByteArrayBase64Serializerto preserve the existing on-disk format forBleScanResultcache files (Map<Int, ByteArray>serialized as{"76": "<base64>"})@SerialNameon all data class fields to lock in the wire format contract and prevent accidental breakage from property renames.classDiscriminator = "type"set explicitly in the Json config to match the existing Moshi polymorphic adapter behavior forDeviceProfilesubtypes.ProximityMessageandRPAChecker, unrelated to Moshi.