Fix: Fix debug log sessions appearing in wrong order#436
Merged
Conversation
…ry names Parse creation time from the embedded filename timestamp instead of relying on filesystem attributes, which are non-deterministic and caused flaky test failures in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed debug log sessions sometimes appearing in the wrong order. Also changed the session directory naming to use a human-readable UTC timestamp (e.g.
20231114T221320Z) instead of raw milliseconds, making it easier to identify sessions when browsing files.Technical Context
parseCreatedAtread filesystem creation time attributes, which differ between sequentially created directories. When two sessions shared the same logical timestamp, the sort tiebreaker (by ID) never kicked in because filesystem times were never truly equal.capod_{version}_{yyyyMMddTHHmmssZ}_{suffix}) instead of querying filesystem attributes. Falls back to filesystem attributes for non-standard filenames.yyyyMMdd'T'HHmmss'Z') was chosen over epoch millis for debuggability — no backward compat concern since the feature hasn't been released yet.