General: Ask to delete debug log after sharing it#435
Merged
Conversation
After sharing a debug log or sending a contact form email, show a dialog on return asking if the send was successful. Confirming deletes the log session and closes/navigates back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
After sharing a debug log or sending a contact form email, a confirmation dialog now appears when returning to the app. Tapping "Done" deletes the log and closes the screen, preventing accidental re-sends.
Technical Context
RecorderActivity(direct debug log share) andContactFormScreen(contact form email) track whether the user left via a share/email intent using ahasShared/hasSentEmailflagLifecycleResumeEffectchecks the flag on resume and shows aMaterialAlertDialogBuilderdialog matching the existing dialog pattern in both screensconfirmSent()deletes the attached debug session (if any) and navigates back vianavUp()ActivityNotFoundException), the flag is reset so no dialog appears on resume