General: Add full-screen upgrade screen with pro benefits overview#427
Merged
General: Add full-screen upgrade screen with pro benefits overview#427
Conversation
Add dedicated Compose upgrade screens for both FOSS and gplay flavors, presenting pro benefits before the purchase/sponsor action. Migrate all upgrade dialog callers to navigate to the new screen instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Technical Context
UpgradeScreen,UpgradeViewModel, andUpgradeNavigationunderupgrade/ui/packageslaunchBillingFlowfromUpgradeRepointerface — billing flow is now encapsulated in the gplayUpgradeViewModelviaBillingDataRepoMainActivitywith aNAVIGATE_TO_UPGRADEintent extra, handled in bothonCreateandonNewIntentisProbecomes true by observingupgradeInfoflowCapodSku.PRO_UPGRADEto avoid false positives from unrelated purchases