Device: Fix profile editing always opening in create mode#407
Merged
Conversation
In create mode, the init block pre-filled _currentState with a default name but left _initialState empty. The hasUnsavedChanges() check saw the non-blank name as a change, triggering the dialog on back press even without user edits. Set _initialState to match _currentState defaults in create mode and unify the comparison logic to always use current != initial.
Navigation 3 doesn't auto-populate SavedStateHandle from NavKey args like Navigation 2.x did. Pass profileId explicitly from the entry lambda through the ScreenHost to the ViewModel via initialize(). Reset initialized flag on every exit path so re-entering a profile reloads fresh data from the repository.
d4rken
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed device profile editing always opening in create mode instead of edit mode. Also fixed a false "unsaved changes" warning appearing when leaving the profile creation screen without making any edits.
Technical Context