refactor(monitor): Make notification builder stateless#398
Merged
Conversation
…tions Replace shared NotificationCompat.Builder + Mutex with a stateless design where each method builds a fresh notification. Introduces a baseBuilder() helper to deduplicate common setup. Removes builderLock and suspend modifiers from getNotification/getNotificationConnected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysing an ANR trace revealed that
MonitorNotificationsheld a singleshared mutable
NotificationCompat.Builderobject, protected by acoroutine
Mutex. This had two problems:getStartupNotification()bypassed the lock entirely, silently violatingthe synchronization protocol
stale
CustomBigContentViewcontent on the shared builderChanges
builderfield andbuilderLock(Mutex) entirelyprivate val openPi: PendingIntent(promoted frominitlocal)private fun baseBuilder(channelId: String)helper for common setupgetBuilder()now takeschannelIdand returns a fresh builder each callgetNotification()andgetNotificationConnected()are no longersuspend(Mutex removed, no coroutine context needed)
Test plan
assembleFossDebug,assembleGplayDebug