fix: Call startForeground() before Hilt DI to prevent timing crash#388
Merged
fix: Call startForeground() before Hilt DI to prevent timing crash#388
Conversation
Move startForeground() before super.onCreate() in MonitorService to avoid ForegroundServiceDidNotStartInTimeException when Hilt DI is slow on backgrounded cold starts. An early minimal notification is shown immediately, then replaced with the full one after DI completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startForeground()with a minimal notification BEFOREsuper.onCreate()(which triggers Hilt DI) to preventForegroundServiceDidNotStartInTimeExceptionon cold background startsstartForeground()callinitblock delegate to the new staticensureChannel()helperPENDING_INTENT_REQUEST_CODEconstant to make PendingIntent coupling explicitContext
When
BluetoothEventReceiverfires in the background (e.g., AirPods connect while phone is in pocket),MonitorService.onCreate()callssuper.onCreate()which triggers Hilt DI for 12 injected fields. The DI chain includes SharedPreferences disk I/O, layout inflation, Moshi reflection, and system service lookups that can exceed the ~5s foreground service timeout on production devices with cold caches.Test plan
./gradlew assembleFossDebugBootCompletedReceiver