fix: Pre-release cleanup of manifest, resource leaks, and dependencies#382
Merged
fix: Pre-release cleanup of manifest, resource leaks, and dependencies#382
Conversation
- Fix BleScanResultReceiver package name in manifest (.bluetooth → .common.bluetooth) - Fix HandlerThread leak in BluetoothManager2 when registerReceiver() throws - Cache battery values in MonitorNotifications to match hardening pattern - Remove duplicate fragment-ktx dependency and align fragment-testing version - Remove deprecated lifecycle-extensions dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release code review fixes before cutting a release from the current
mainbranch (which includes the WorkManager→ForegroundService migration and battery display crash hardening)..bluetooth.BleScanResultReceiver→.common.bluetooth.BleScanResultReceiver— the manifest entry didn't match the actual class locationhandlerThread.quitSafely()beforeclose(e)whenregisterReceiver()throws, sinceawaitClosenever executes in that path1.4.1declaration, keep1.6.1, and updatefragment-testingto matchlifecycle-extensions:2.2.0has been deprecated since 2019; all its functionality is covered by the other lifecycle deps already declaredTest plan
./gradlew assembleFossDebug— clean build./gradlew testFossDebugUnitTest— all tests pass./gradlew lintFossDebug— no new lint issues (pre-existing errors unchanged)