fix: Harden battery display against native crashes#377
Merged
Conversation
Remove thread-unsafe shared RelativeDateTimeFormatter instance and cache battery percentage values to local variables at all call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RelativeDateTimeFormatterinstance that caused memory corruption when accessed from multiple threads concurrentlygetBatteryLevel*extension functions with a singleformatBatteryPercenthelperContext
Multiple native crashes (SIGSEGV in ART) were reported in
PodDeviceExtensionsKtfunctions during RecyclerView binding and notification building on background threads. The shared staticRelativeDateTimeFormatteris not thread-safe and was the most likely cause of heap corruption. Battery percentage caching is an additional hardening measure.Test plan
./gradlew assembleFossDebugcompiles./gradlew testFossDebugUnitTestpasses