Refactor PlayPause logic and fix behavior for SinglePods (e.g. AirPods Max)#355
Merged
Refactor PlayPause logic and fix behavior for SinglePods (e.g. AirPods Max)#355
Conversation
d4rken
force-pushed
the
SinglePods-PlayPause
branch
from
97a1b9c to
3c7e10e
Compare
…s Max) Fix edge case where removing a pod while both were in ears didn't trigger pause in one-pod mode. The aggregate boolean (isEitherPodInEar) stayed true, masking the individual pod removal. See thread by `ZV`: https://discord.com/channels/548521543039189022/1437499888068726814
d4rken
force-pushed
the
SinglePods-PlayPause
branch
2 times, most recently
from
ea8e360 to
2c3dcc5
Compare
Add missing test cases for single-pod one-pod-mode pause direction, EarDetectionState single-pod properties, and normal-mode steady-state. Fix stale test comments that incorrectly claimed tests would fail. Clarify onePodMode flow combine pattern and isWorn field semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix edge case where removing a pod while both were in ears didn't trigger pause in one-pod mode. The aggregate boolean (isEitherPodInEar) stayed true, masking the individual pod removal.
See thread by
ZV:https://discord.com/channels/548521543039189022/1437499888068726814