Repository navigation
Commit 34b7c3d
authored
fix(storage): yield only direct children from FsspecStore.list_dir (zarr-developers#4402)
* fix(storage): yield only direct children from FsspecStore.list_dir
An HTTP listing is scraped from the links on an HTML index page. A link to
the site root ("/") becomes a self-link that list_dir reduced to "", so a
group listed itself as a member named "". In-page anchors ("#usage") became
keys whose metadata fetch returned the HTML page, and directories carried a
trailing "/".
list_dir now skips http(s) entries with a fragment or query, strips the
trailing "/", drops empty or nested names, and yields each name once.
Closes zarr-developers#3575
Assisted-by: ClaudeCode:claude-opus-5-5
* docs: add changelog fragment for zarr-developers#4402
Assisted-by: ClaudeCode:claude-opus-5-5
* fix(storage): scope HTTP link filtering to the child name in list_dir
The "#"/"?" check ran on the whole URL, so a store rooted at a URL
containing either character would list nothing. It now runs on the name
left after stripping the prefix. HTTP names are also normalized with
posixpath.normpath, so "./a" lists as "a" and "./" no longer lists as ".".
Assisted-by: ClaudeCode:claude-opus-5-51 parent eb2ce59 commit 34b7c3d
3 files changed
Lines changed: 75 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
431 | 432 | | |
432 | 433 | | |
433 | 434 | | |
434 | | - | |
435 | | - | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
436 | 452 | | |
437 | 453 | | |
438 | 454 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
561 | 564 | | |
562 | 565 | | |
563 | 566 | | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
564 | 616 | | |
565 | 617 | | |
566 | 618 | | |
| |||
0 commit comments