Many to one fixes#5
Merged
d-montgomery merged 6 commits intod-montgomery:many-to-onefrom Feb 16, 2026
Merged
Conversation
Owner
d-montgomery
left a comment
d-montgomery
left a comment
There was a problem hiding this comment.
This looks good to me. I'm not sure what to do about the comment you made in Drag.H for when mass_trans=false. I haven't done any testing with this flag, and to be honest don't really know when it would be needed?
d-montgomery
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This graphic summarizes the issue we currently have with many-to-one + Manifold (don't know num_chemspecies from the manifold a priori to allocate the right amount of memory on GPU):
The implemented fix is a little bit different than outlined in the figure. A modification is made so that, when spray is active, the routines to get chemspecies from the manifold model only return the chemspecies involved in spray phase change. This ensures that num_chemspecies <= SPRAY_FUEL_NUM, so we can always be sure to allocate enough space for the data.