Skip to content

Comments

Add PEP420 namespace support.#2946

Merged
scoder merged 4 commits intocython:masterfrom
CnlPepper:master
May 6, 2019
Merged

Add PEP420 namespace support.#2946
scoder merged 4 commits intocython:masterfrom
CnlPepper:master

Conversation

@CnlPepper
Copy link
Contributor

Should address issue #2918.

Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scoder
Copy link
Contributor

scoder commented May 5, 2019

The test can be disabled for Py2 by adding it to the VER_DEP_MODULES exclusions in runtests.py, section (3,3).

@scoder
Copy link
Contributor

scoder commented May 6, 2019

Thanks

@scoder scoder merged commit c2386df into cython:master May 6, 2019
@scoder scoder added this to the 3.0 milestone May 6, 2019
@scoder scoder added Build System Python Semantics General Python (3) language semantics labels May 6, 2019
mkoeppe added a commit to passagemath/upstream-cython that referenced this pull request Jul 23, 2022
randomir added a commit to randomir/dwave-samplers that referenced this pull request May 26, 2025
Requires cython>=3, see cython/cython#2946.

Extension names have to be explicitly specified.
randomir added a commit to randomir/dwave-samplers that referenced this pull request May 28, 2025
Requires cython>=3, see cython/cython#2946.

Note: all extension module names have to be explicitly specified.
Auto-detection from a glob pattern skips parent directories without
`__init__.py`, i.e. does not properly detect pep420 namespace packages.
randomir added a commit to randomir/dwave-gate that referenced this pull request May 31, 2025
Also make sure cython recognizes native namespace packages.

Requires cython>=3, see cython/cython#2946.

Note: all extension module names have to be explicitly specified.
Auto-detection from a glob pattern skips parent directories without
`__init__.py`, i.e. does not properly detect pep420 namespace packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build System Python Semantics General Python (3) language semantics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants