feat: replace dashboardUrl by resultsUrl#916
Merged
chrisbreiding merged 2 commits intocypress-io:masterfrom May 22, 2023
Merged
feat: replace dashboardUrl by resultsUrl#916chrisbreiding merged 2 commits intocypress-io:masterfrom
chrisbreiding merged 2 commits intocypress-io:masterfrom
Conversation
|
|
Let's go with |
MikeMcC399
force-pushed
the
add/cloudRunUrl
branch
from
370d497 to
66319de
Compare
MikeMcC399
changed the title
Collaborator
Author
Thanks for the decision on the name. I've updated the PR contents accordingly. There are still references to the "Cypress Cloud" in text presented to users. This makes sense in terms of relating the parameter to other documentation. (The branch name no longer reflects the name of the parameter. To change this would have required closing this PR and submitting a new one. Once the PR is merged I would delete the branch in this fork in any case.) |
MikeMcC399
force-pushed
the
add/cloudRunUrl
branch
from
66319de to
945147d
Compare
chrisbreiding
requested changes
May 22, 2023
This comment was marked as outdated.
This comment was marked as outdated.
chrisbreiding
approved these changes
May 22, 2023
mjhenkes
approved these changes
May 22, 2023
|
Thanks, @MikeMcC399! |
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #909.
This PR adds a GitHub step output
cloudRunUrlresultsUrlfor recording, providing a name which is not tied to the branding name of Cypress Dashboard or Cypress Cloud. This is a replacement fordashboardUrl.The GitHub step output
dashboardUrl, stemming from the previous Cypress Dashboard branding, continues to function and is documented as deprecated.Documentation and examples are updated accordingly.
examples/v9 are left using
dashboardUrl