Skip to content

Commit a55856e

Browse files
authored
feat(deps): update action from node16 to node20 (#995)
BREAKING CHANGE: Update action from node16 to node20 update @types/node to 20.5.0
1 parent 157e672 commit a55856e

8 files changed

Lines changed: 19 additions & 17 deletions

File tree

.github/workflows/check-dist.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Setup Node
2323
uses: actions/setup-node@v3
2424
with:
25-
node-version: 16.16.0
25+
node-version: 20.5.0
2626
- uses: bahmutov/npm-install@v1
2727
- run: npm run format
2828
- run: npm run build

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ jobs:
1414
- name: Setup Node
1515
uses: actions/setup-node@v3
1616
with:
17-
# Action runs: using: node16 as defined in
17+
# Action runs: using: node20 as defined in
1818
# https://github.com/cypress-io/github-action/blob/master/action.yml
1919
# Node.js minor version is aligned to
2020
# https://github.com/actions/runner/blob/main/src/Misc/externals.sh
21-
node-version: 16.16.0
21+
node-version: 20.5.0
2222
- uses: bahmutov/npm-install@v1
2323
- run: npm run format
2424
- run: npm run build

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.17.1
1+
20

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ See [Releases](https://github.com/cypress-io/github-action/releases) for full de
66

77
| Version | Changes |
88
| ------- | ------------------------------------------------------------------------------------------------------------------------------------ |
9+
| v6.0.0 | Action runs under Node.js 20 instead of Node.js 16. |
910
| v5.8.1 | Examples remove Node.js 19. End of support for Node.js 19. |
1011
| v5.8.0 | Add GitHub step output `resultsUrl`. Deprecate `dashboardUrl`. |
1112
| v5.7.0 | Add basic Yarn Modern Plug'n'Play support. |

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ See the example project [component-tests](examples/component-tests/) and the [ex
117117

118118
**Best practice:**
119119

120-
Our examples specify using branch [v5](https://github.com/cypress-io/github-action/tree/v5) which is the action's latest major version:
120+
Our examples specify using branch [v5](https://github.com/cypress-io/github-action/tree/v5) which is the action's recommended major version:
121121

122122
```yml
123123
- name: Cypress run
@@ -1501,7 +1501,7 @@ jobs:
15011501

15021502
### Support
15031503

1504-
Node.js is required to run this action. The current version `v5` supports:
1504+
Node.js is required to run this action. The currently recommended version `v5` supports:
15051505

15061506
- **Node.js** 16.x
15071507
- **Node.js** 18.x
@@ -1515,15 +1515,16 @@ and is generally aligned with [Node.js's release schedule](https://github.com/no
15151515

15161516
[![Node versions example](https://github.com/cypress-io/github-action/workflows/example-node-versions/badge.svg?branch=master)](.github/workflows/example-node-versions.yml)
15171517

1518-
Cypress itself runs with a fixed Node.js version specified by the [runs.using](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions) parameter of [action.yml](action.yml). For `github-action@v5` this is `node16`.
1518+
Cypress itself runs with a fixed Node.js version specified by the [runs.using](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions) parameter of [action.yml](action.yml). `github-action@v5` uses `node16` and `github-action@v6` uses `node20`.
15191519

15201520
## Changelog
15211521

15221522
View the [CHANGELOG](./CHANGELOG.md) document for an overview of version changes.
15231523

15241524
## Compatibility
15251525

1526-
- `v5` is the recommended version of [cypress-io/github-action](https://github.com/cypress-io/github-action)
1526+
- `v6` is provided for early adopters needing full `node20` support
1527+
- `v5` is the current recommended version
15271528
- `v4` is the minimum version required for Cypress `10.x` and later
15281529

15291530
Pay attention to any GitHub Actions deprecation warnings shown in logs which may recommend updating.

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ outputs:
9797
resultsUrl:
9898
description: 'Cypress Cloud URL if the run was recorded'
9999
runs:
100-
using: 'node16'
100+
using: 'node20'
101101
main: 'dist/index.js'
102102
branding:
103103
color: 'green'

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"supports-color": "9.3.1"
4747
},
4848
"devDependencies": {
49-
"@types/node": "18.17.5",
49+
"@types/node": "20.5.0",
5050
"@vercel/ncc": "0.36.1",
5151
"husky": "8.0.3",
5252
"markdown-link-check": "3.11.1",

0 commit comments

Comments
 (0)