Skip to content

Commit 448155c

Browse files
authored
fix(cli): use verbose Listr renderer in CI for install + verify output (#33890)
1 parent 01cd887 commit 448155c

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎cli/CHANGELOG.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!-- See ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
2-
## 15.15.1
2+
## 15.16.0
33

44
**Features:**
55

@@ -9,6 +9,7 @@
99
**Bugfixes:**
1010

1111
- Fixed an issue on Node 24.16.0+ and Node 26.1.0+ where installing Cypress could silently extract only the first file from the binary archive, causing the test runner to fail to launch with a "Cypress binary is missing" error. Addresses [#33891](https://github.com/cypress-io/cypress/issues/33891). Addressed in [#33887](https://github.com/cypress-io/cypress/pull/33887).
12+
- Fixed a regression in [15.14.2](#15-14-2) where the `cypress install` and `cypress verify` task list output could render one character per line in CI environments that allocate a pseudo-TTY without setting `COLUMNS`. Fixed in [#33890](https://github.com/cypress-io/cypress/pull/33890).
1213
- Fixed an issue where Cypress would abort the process and show a crash dialog when it received a SIGINT. Fixes [#29228](https://github.com/cypress-io/cypress/issues/29228). Fixed in [#33542](https://github.com/cypress-io/cypress/pull/33542/).
1314
- Fixed an issue where the [`clientCertificates`](https://docs.cypress.io/guides/references/client-certificates) config option failed to load ECDSA (EC) PEM or PKCS#12 client certificates. Fixes [#33767](https://github.com/cypress-io/cypress/issues/33767). Fixed in [#33799](https://github.com/cypress-io/cypress/pull/33799).
1415
- Fixed an issue where clicking "back to projects" or switching projects while a project's initial config load was still in flight could fail. Fixed in [#33810](https://github.com/cypress-io/cypress/pull/33810).

‎cli/lib/tasks/install.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import os from 'os'
33
import path from 'path'
44
import chalk from 'chalk'
55
import Debug from 'debug'
6-
import { Listr } from 'listr2'
6+
import { Listr, PRESET_TIMESTAMP } from 'listr2'
77
import type { ListrTask, ListrContext } from 'listr2'
88
import logSymbols from 'log-symbols'
99
import { stripIndent } from 'common-tags'
@@ -307,6 +307,10 @@ const start = async (options: StartOptions = {}): Promise<ListrContext | void> =
307307
const taskRunner = new Listr(
308308
tasks,
309309
{
310+
// In CI we want timestamped, line-per-event output. Locally,
311+
// the default in-place spinner is the better experience.
312+
renderer: util.isCi() ? 'verbose' : 'default',
313+
...(util.isCi() && { rendererOptions: { timestamp: PRESET_TIMESTAMP } }),
310314
silentRendererCondition: () => logger.logLevel() === 'silent',
311315
},
312316
)

‎cli/lib/tasks/verify.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import _ from 'lodash'
22
import chalk from 'chalk'
3-
import { Listr } from 'listr2'
3+
import { Listr, PRESET_TIMESTAMP } from 'listr2'
44
import Debug from 'debug'
55
import { stripIndent } from 'common-tags'
66
import Bluebird from 'bluebird'
@@ -228,6 +228,10 @@ async function verifyBinary (installedVersion: string, binaryDir: string, option
228228
)
229229
},
230230
}], {
231+
// In CI we want timestamped, line-per-event output. Locally,
232+
// the default in-place spinner is the better experience.
233+
renderer: util.isCi() ? 'verbose' : 'default',
234+
...(util.isCi() && { rendererOptions: { timestamp: PRESET_TIMESTAMP } }),
231235
silentRendererCondition: () => logger.logLevel() === 'silent',
232236
})
233237

0 commit comments

Comments
 (0)