Conversation
Contributor
Author
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
rndmerle
pushed a commit
to rndmerle/code-coverage
that referenced
this pull request
Apr 25, 2020
* chore: refactor * adding detecting folder that matches current folder root * move utility functions * feat: find matching folder example * add docker paths example to circleci * exclude utils file from coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the application is instrumented inside a Docker container, all paths have different prefix. For example, local paths could be
But when you run app in Docker container the coverage will be in some local path, so that file
main.jswill produce in.nyc_output/out.jsonfileThen local Cypress running outside the container tries to generate the report - and produces an empty report, since there is no file "/var/www/site/main.js"
In this PR, if ALL files are missing, we try to find common prefix in paths, such that IF this prefix is replaced with
process.cwd()then all files are found.So if you run in
/root/app, then before generating the report, this plugin will say: "Ohh, if I replace/var/www/sitewith/root/app/srcthenmain.jsis found!" And if the same prefix works for all files, then it updates the prefix and generates the reports.Note: it could check the
hashas well to make sure the files are exactly what we expect to find.