add solana#816
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## staging #816 +/- ##
============================================
+ Coverage 5.83% 41.20% +35.36%
============================================
Files 741 54 -687
Lines 70283 4638 -65645
============================================
- Hits 4100 1911 -2189
+ Misses 66183 2727 -63456 ☔ View full report in Codecov by Sentry. |
|
|
||
| @override | ||
| bool validateAddress(String address) { | ||
| RegExp regex = RegExp(r'^[a-zA-Z0-9]{44}$'); |
| // Rent exemption of Solana | ||
| final accInfo = await rpcClient.getAccountInfo((await _getKeyPair()).address); | ||
| final minimumRent = await rpcClient.getMinimumBalanceForRentExemption(accInfo.value!.data.toString().length); | ||
| var spendableBalance = balance.value - minimumRent; |
There was a problem hiding this comment.
What if we want to send more than the minimum rent out of the wallet?
There was a problem hiding this comment.
The account have to be closed to fully send all funds.
sneurlax
left a comment
sneurlax
left a comment
There was a problem hiding this comment.
Looks good to me although I still need to review if Tor usage works with the RpcClient as used here
|
@detherminal I merged your changes to the The notes here on this PR should be followed up on but we might convert them to issues and leave them to be upon improved later |
3 participants
Added Solana with all functionalities:
etc. etc.