vmm: live migration asynchronization (dedicated thread) #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
asynchronization
branch
from
2c3540c to
349fa34
Compare
phip1611
changed the title
phip1611
force-pushed
the
asynchronization
branch
from
cb015f8 to
13117d9
Compare
phip1611
changed the title
amphi
reviewed
Nov 3, 2025
amphi
reviewed
Nov 3, 2025
phip1611
force-pushed
the
asynchronization
branch
4 times, most recently
from
c18c399 to
c1055f8
Compare
amphi
reviewed
Nov 12, 2025
phip1611
force-pushed
the
asynchronization
branch
from
c323c24 to
871a6a1
Compare
26 tasks
phip1611
force-pushed
the
asynchronization
branch
2 times, most recently
from
7a7e248 to
7d1e566
Compare
phip1611
force-pushed
the
asynchronization
branch
3 times, most recently
from
18baf46 to
ec84b5d
Compare
phip1611
force-pushed
the
asynchronization
branch
from
ec84b5d to
6eab06b
Compare
olivereanderson
left a comment
olivereanderson
left a comment
There was a problem hiding this comment.
This looks quite good,
I mostly have some nits and there are a few comments that I think can be improved.
I am wondering whether a design using the scoped thread API could also work here, but that does not need to be explored now.
phip1611
force-pushed
the
asynchronization
branch
from
6eab06b to
937f880
Compare
phip1611
force-pushed
the
asynchronization
branch
from
937f880 to
17b084e
Compare
Member
Author
|
@olivereanderson since your review, I've simplified Code diff should be visible here: https://github.com/cyberus-technology/cloud-hypervisor/compare/6eab06b350aa0b504874a652735a328e23beaa21..937f8804a84ffb96ca8fcb9c2e8d279dde49933d |
phip1611
force-pushed
the
asynchronization
branch
from
17b084e to
b99f86f
Compare
phip1611
force-pushed
the
asynchronization
branch
3 times, most recently
from
2aa0c4f to
4a372b4
Compare
olivereanderson
approved these changes
Nov 21, 2025
phip1611
force-pushed
the
asynchronization
branch
from
4a372b4 to
fb4b932
Compare
scholzp
requested changes
Nov 21, 2025
scholzp
left a comment
scholzp
left a comment
There was a problem hiding this comment.
LGTM! Only one thing I have a question about.
phip1611
force-pushed
the
asynchronization
branch
from
fb4b932 to
697649d
Compare
scholzp
approved these changes
Nov 21, 2025
amphi
reviewed
Nov 24, 2025
amphi
reviewed
Nov 24, 2025
phip1611
force-pushed
the
asynchronization
branch
2 times, most recently
from
f9db2a3 to
1ae2ba4
Compare
This is a pre-requisite for the following commit which puts the migration into a dedicated thread. It allows the VMM to react to migration events (success/failure). The commit series was inspired by @ljcore [0] but was changed quite significantly. [0] cloud-hypervisor#7038 Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
This puts the send-migration action into a dedicated thread. This means: 1. The send-migration call will exit sooner (just trigger the migration) 2. Other API Call will not be possible as the VM's ownership is transferred from the VMM to the migration thread. E.g., hotplugging won't work (which is good). 3. If the migration causes the VMM process to crash, this currently can't be observed. A mechanism to query the migration status doesn't exist. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
The commit prepares to properly handle API events during ongoing live-migrations. The VmInfo call is currently not working when a VM is migrating. This will be addressed in a follow-up as part of statistics migration statistics about ongoing live-migrations. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Once we have a mechanism to query the progress of an ongoing live-migration, we can remove this workaround. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
asynchronization
branch
from
1ae2ba4 to
86eb8a8
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR prepares the live-migration statistics. For that, we need to ensure that
SendMigrationwon't block the whole VMM thread's event loop all the time ("asynchronization").Further, this PR lays the groundwork to prevent VM change events (resize, hotplug) when a migration is ongoing.
Changes
Please review this commit-by-commit.
Closes https://github.com/cobaltcore-dev/cobaltcore/issues/293 and https://github.com/cobaltcore-dev/cobaltcore/issues/230
Steps Before Merge