Remove incorrect or too restrictive validations#355
Merged
sveinse merged 3 commits intocustom-components:masterfrom Nov 9, 2025
Merged
Remove incorrect or too restrictive validations#355sveinse merged 3 commits intocustom-components:masterfrom
sveinse merged 3 commits intocustom-components:masterfrom
Conversation
We don't use the response for anything, and it is an undocumented API, so we shouldn't require any validation.
Contributor
Author
|
Addresses #354 Given that this issue only applies to the cable lock and the HMI-brightness, I don't think it is critical enough to warrant an immediate release, I think we can leave it for a bit and see if any additional issues pop up. |
For users without the Owner role, AuthenticationType is not included in the Installation response, which causes a problem in the initial setup of the integration. Since we don't use Authentication type for anything (other than displaying it in a sensor), we can just remove the requirement.
steinmn
changed the title
Contributor
Author
sveinse
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation of ChargerLocalSettings-response:
We don't use the response for anything, and it is an undocumented API, so we shouldn't require any validation.
Validation of Installation(s)-response:
Users without the Owner role don't get the full installation object, specifically not the AuthenticationType-entry that was in the validation. Since the Installations-response includes all installations the user has access to, not just the one(s) they have added to HA, that causes issues. Since we don't use Authentication type for anything (other than displaying it in a sensor), we can just remove the requirement.
Fixes #354. Fixes #357