Fix TypeError-crash for users without access to Hierarchy-endpoint#321
Merged
sveinse merged 2 commits intocustom-components:masterfrom Sep 20, 2025
Merged
Conversation
Handle a 204(no content)-response the same way we have handled a 403-response previously.
Contributor
Author
|
@sveinse I think this means we need to consider a 0.8.3-beta soon, though I would like to hear from Zaptec if there are any more recent/upcoming API changes we need to handle as well. |
sveinse
approved these changes
Sep 20, 2025
Collaborator
sveinse
left a comment
sveinse
left a comment
There was a problem hiding this comment.
I'd like to hear from Zaptec too before pushing a new release.
PR approved.
sveinse
reviewed
Sep 20, 2025
Comment on lines
240
to
246
| if not hierarchy: | ||
| _LOGGER.warning( | ||
| ("No hierarchy returned for installation %s. The user might not have access"), | ||
| self.qual_id, | ||
| ) | ||
| self.chargers = [] | ||
| return |
Collaborator
There was a problem hiding this comment.
On second thought. Please, add a comment with date on it saying that Zaptec seems to return 204 empty data when the user doesn't have access instead of returning an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle a 204(no content)-response the same way we have handled a 403-response previously.
Fixes #320