Add unit tests for zconst and print test coverage in gh-action#318
Merged
sveinse merged 4 commits intocustom-components:masterfrom Sep 3, 2025
Merged
Add unit tests for zconst and print test coverage in gh-action#318sveinse merged 4 commits intocustom-components:masterfrom
sveinse merged 4 commits intocustom-components:masterfrom
Conversation
(bonus: tests caught a typo in zconst.py)
sveinse
reviewed
Sep 3, 2025
Collaborator
sveinse
left a comment
sveinse
left a comment
There was a problem hiding this comment.
Generally this looks good. Some comments to discuss.
Ensures init_zconst is run before every test, but we only call the Zaptec API once.
sveinse
reviewed
Sep 3, 2025
sveinse
reviewed
Sep 3, 2025
sveinse
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(bonus: tests caught a typo in zconst.py)