Cleanup misc - rename to utils, add typing and tests#317
Merged
sveinse merged 3 commits intocustom-components:masterfrom Sep 1, 2025
Merged
Cleanup misc - rename to utils, add typing and tests#317sveinse merged 3 commits intocustom-components:masterfrom
sveinse merged 3 commits intocustom-components:masterfrom
Conversation
Contributor
|
Could we maybe rename the file to utils.py or something instead? Misc just seems like a draft to me. |
Collaborator
Author
|
I have no strong opinion between either, so why not. I'll do the change. |
sveinse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the cleanup of zaptec/misc.py. All ruff errors have been removed (and even some caught by the pyright static type checker) and tests for the functions have been added.