Norwegian Translation#295
Conversation
Added translation key for charger entity, to support easy identification of current entity from other integration.
Norwegian Bokmål
Norwegian Nynorsk
|
As mentioned on dirkgroenen/hass-evse-load-balancer#52, I think you can do this a lot simpler without relying on the detour through We are gradually trying to align with HA-core code-standards, and entities with a large number of attributes are quite unpopular among the core team as far as I can tell. The |
Oh, it is? Do you have links to this? Because these special binary_sensors we have for each charger and installation are a neat way to collect arbitrary information from zaptec without needing a SW update to access new entities. Let's move this discussion to a separate issue, please. |
| name="Charger", | ||
| translation_key="charger", # added to facilitate for other integrations |
There was a problem hiding this comment.
This change puzzles me a bit, please elaborate why. What's wrong with the old? As the original comment stated, the exact point is not to have translation on this entity. Moreso, I cannot see any translation for "charger", so I don't quite get this.
There was a problem hiding this comment.
Thanks for the comment. I'll sure do elaborate -> Check this comment here. The need of the translation key emerged as the other integration already used translation_keys to identify entities.
I guess the actual translation files (.json's) could have been posted in a separate request, to avoid mixing the usage.
There was a problem hiding this comment.
That would be nice to move that to another PR, because I think the translation itself is ready for merge.
|
andersop91
changed the title
This reverts commit 3cd6084.
steinmn
left a comment
steinmn
left a comment
There was a problem hiding this comment.
Bittelitt småpirk, men eg veit ikkje heilt om eg er einig med meg sjølv heller, så går nok an å overtala meg om du har gode argument.
Co-authored-by: steinmn <[email protected]>
| "off": "Ikkje krevd", | ||
| "on": "Krevd" | ||
| "off": "Ikkje kravd", | ||
| "on": "kravd" |
There was a problem hiding this comment.
@andersop91 Kan du endre denne til å ver med stor forbokstav?
There was a problem hiding this comment.
Sjølvsagt! Her gjekk det litt fort i svingane 👎
3 participants
Added translation for Norwegian Bokmål and Norwegian Nynorsk. Translation done by ChatGPT and revised afterwards.
Added translation key for binary_sensor.charger entity. This to support easy identification of the entity from other integration (https://github.com/dirkgroenen/hass-evse-load-balancer).