Skip to content

Comments

Add breaking changes warning about blueprint#288

Merged
sveinse merged 1 commit intocustom-components:masterfrom
steinmn:add-blueprint-warning-to-readme
Aug 17, 2025
Merged

Add breaking changes warning about blueprint#288
sveinse merged 1 commit intocustom-components:masterfrom
steinmn:add-blueprint-warning-to-readme

Conversation

@steinmn
Copy link
Contributor

@steinmn steinmn commented Aug 17, 2025

No description provided.

@steinmn steinmn mentioned this pull request Aug 17, 2025
Copy link
Collaborator

@sveinse sveinse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Added one small comment.

Comment on lines +416 to +420
The changes to the Charger mode will also cause the
[Load Balancing blueprint](#load-balancing-your-charger) compatible with 0.7.x
to stop working. There is an [open PR](https://github.com/svenakela/ha/pull/10)
for a 0.8.x-compatible version. If you use this blueprint, or a variant of it,
you will need to update your blueprint/automation accordingly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add an information box that the blueprint is language dependent, and that it might need modification if not using English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that belongs in the
blueprint readme, not in this repo. We already refer to that for "How to set up the automation, how the logic works and what all settings mean".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. However, it seems we're getting the issues about it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in this case we were the ones who broke it, so that's fair imo.

On the other hand, I see we have a blueprint issue in #179, but again, I think that belongs in the svenakela/ha-repo, not here. If there's anything that needs to be done inside the integration to fix it, then sure, but the issue with #179 is purely from the setup of the blueprint.

@sveinse sveinse added this to the v0.8.2 milestone Aug 17, 2025
@sveinse sveinse merged commit 5b1fae2 into custom-components:master Aug 17, 2025
3 checks passed
@steinmn steinmn deleted the add-blueprint-warning-to-readme branch August 17, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants