Merged
Conversation
* Use `obj.qual_id` instead of `obj.id` for logging, due to not log the full UID * Improve diagnostics functions. Use more natuaral language in variables * Improve and refactor Redactor * Some optimizations in api
steinmn
approved these changes
Jul 28, 2025
|
|
||
| def add_redact(self, obj, ctx=None, key=None, redact=None) -> str: | ||
| def dumps(self) -> str: | ||
| """Dump the redation database in a readable format.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Dump the redation database in a readable format.""" | |
| """Dump the redaction database in a readable format.""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
obj.qual_idinstead ofobj.idfor logging, due to not log the full UID