Updated ruff settings and fixed the simplest errors in the code#247
Merged
sveinse merged 2 commits intocustom-components:masterfrom Jul 27, 2025
Merged
Updated ruff settings and fixed the simplest errors in the code#247sveinse merged 2 commits intocustom-components:masterfrom
sveinse merged 2 commits intocustom-components:masterfrom
Conversation
steinmn
reviewed
Jul 27, 2025
Contributor
steinmn
left a comment
steinmn
left a comment
There was a problem hiding this comment.
Running ruff format . also adds updates for number.py and update.py, please include those as well.
Otherwise LGTM
Collaborator
Author
|
This PR changes the number of characters per line, which in turn changes the behavior of the formatter. For the sake of the other PRs, this should be implemented ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the most low-hanging fruits of the lint errors in the code. The PR also configures a few exceptions to ruff, that are too strict. I've used HA as a template to guide what settings should be enabled or disabled.
There are more lint errors remaining, and when someone takes a stab at it, we should also continue to evaluate if the rule is valid or not. We should keep looking at the extensive HA setting to see if we should mirror HAs exception.