Repository navigation
Conversation
vszakats
marked this pull request as draft
March 4, 2026 04:01
vszakats
changed the title
vszakats
force-pushed
the
clangtidymore2
branch
from
March 21, 2026 12:51
ccd5eff to
2773f32
Compare
vszakats
force-pushed
the
clangtidymore2
branch
3 times, most recently
from
April 7, 2026 13:48
326112f to
cddcdee
Compare
vszakats
marked this pull request as ready for review
April 11, 2026 00:22
vszakats
changed the title
```
/home/runner/work/curl/curl/lib/cf-socket.c:1597:52: error: operator has equivalent nested operands [misc-redundant-expression,-warnings-as-errors]
1597 | pfd[0].events = POLLRDNORM | POLLIN | POLLRDBAND | POLLPRI;
| ^
631 warnings generated.
```
https://github.com/curl/curl/actions/runs/22603450627/job/65490313441?pr=20794
vszakats
force-pushed
the
clangtidymore2
branch
from
April 13, 2026 23:24
b0348df to
b9ef51f
Compare
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Also enable check in clang-tidy. Cherry-picked from curl#20794 Closes curl#21256
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
- enable three checks: - bugprone-invalid-enum-default-initialization - bugprone-sizeof-expression - readability-inconsistent-declaration-parameter-name (strict) - fix remaining discrepancies with arg names in prototypes and implementation, in strict mode. - document reason for some checks tested but not enabled. Closes curl#20794
vszakats
pushed a commit
that referenced
this pull request
Aug 17, 2026
Eleven arguments are named one way in the header and another in the definition. the compiler only checks types so nothing is broken, but the header is what people read first, and then the name changes under them in the source: ``` curl_dbg_malloc size -> wantedsize curl_dbg_calloc n, size -> wanted_elements, wanted_size curl_dbg_realloc size -> wantedsize curl_dbg_strdup src -> source r_freeaddrinfo res -> cahead my_get_line fp, db -> input, buf curl_slist_append_ccsid l -> list curl_version_info_ccsid cid -> ccsid curl_easy_setopt_ccsid curl -> easy ``` Follow-up to df60148 #20794 Closes #22550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and implementation, in strict mode.