GHA/macos: let gcc dictate the configured Apple SDK #15518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered earlier, Homebrew gcc is built against a specific Apple SDK and doesn't work when matched up with a different SDK, e.g. the one advertised as default by the macos runner image. Before this patch this was resolved with brute force by zapping the hack-layer gcc component to avoid the bad interference. This worked for us, but it's fragile, accidental and doesn't translate to any real-world build environment. Thus, impractical. This patch avoids this by explicitly configuring the SDK gcc was built for and meant to be used with. It assumes that the gcc binaries preinstalled on the runner images always ship with the SDK version they reference. It's non-trivial to guarantee that given the different build/release/update cycles of the projects involved, but since this is the only officially supported way to use them, hopefully this is ensured to be kept in sync. Since we don't do `brew update`, there is emphasis on preinstalled. In curl-for-win CI jobs we do `brew update` and expect that scenario to work too. Follow-up to c349bd6 curl#14097
vszakats
added
build
CI
vszakats
changed the title
vszakats
changed the title
4 tasks
vszakats
force-pushed
the
gha-mac-gcc-reshuffle
branch
from
777da30 to
4972768
Compare
vszakats
force-pushed
the
gha-mac-gcc-reshuffle
branch
2 times, most recently
from
9b0e81d to
71c6b87
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
As discovered earlier, Homebrew gcc is built against a specific Apple SDK version and doesn't work when matched up with a different version, e.g. the one advertised as default by the macos runner image. Before this patch this was resolved with brute force by zapping the hack-layer gcc component to avoid the bad interference. This worked for us, but it's fragile, accidental and doesn't translate to real-world build environments. Thus, impractical. Avoid this by explicitly selecting the SDK version gcc was built for and meant to be used with, as shown by `gcc --print-sysroot`. It assumes that the gcc binaries preinstalled on the runner images always ship with the SDK version they reference. It also assumes this works with and without `brew update`. Also: - add 4 quick build-only jobs to test all gcc/macos combos. - list SDKs offered via CommandLineTools. Suggested-by: Bo Anderson Ref: Homebrew/homebrew-core#194778 (comment) Follow-up to c349bd6 curl#14097 Closes curl#15518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered earlier, Homebrew gcc is built against a specific Apple
SDK version and doesn't work when matched up with a different version,
e.g. the one advertised as default by the macos runner image.
Before this patch this was resolved with brute force by zapping the
hack-layer gcc component to avoid the bad interference. This worked
for us, but it's fragile, accidental and doesn't translate to
real-world build environments. Thus, impractical.
Avoid this by explicitly selecting the SDK version gcc was built for and
meant to be used with, as shown by
gcc --print-sysroot.It assumes that the gcc binaries preinstalled on the runner images
always ship with the SDK version they reference. It also assumes
this works with and without
brew update.Also:
Suggested-by: Bo Anderson
Ref: Homebrew/homebrew-core#194778 (comment)
Follow-up to c349bd6 #14097