Replies: 3 comments 4 replies
-
|
Test 1132 is meant to verify that files (in |
Beta Was this translation helpful? Give feedback.
-
|
On 16 Feb 2021, at 08:14, Daniel Stenberg ***@***.***> wrote:
Test 1132 is meant to verify that files (in lib/) that use memory functions include memdebug.h and curl_memory.h. It does this with the tests/mem-include-scan.pl script. If any of the files you list actually use memory functions then we need to figure out why the script fails and fix it!
Looking at a few select of thes files in lib/ they don't qualify as they dont have allocations. The files in src/ aren't included as 1132 only checks lib/
|
Beta Was this translation helpful? Give feedback.
-
|
So the answer is that it's not always supposed to be included and as @bagder noted there's a script memanalyze.pl that determines which files need it. The PR I was working on #6602 actually needed functions and function-like macros exempt from memdebug, so I have adjusted the PR to reflect that. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Most lib and src source files have memdebug as the last include, but some don't have it at all.
curl/src/tool_main.c
Lines 53 to 58 in 2f33be8
Isn't it always supposed to be the last include? Why is it in some files but not others? I will need it in src/tool_filetime.c for the Curl_safefree macro (#6602).
Beta Was this translation helpful? Give feedback.
All reactions