CI: Use GCP-backed kernel cache in Windows CI#9738
Conversation
|
/test windows,cuda130 This will take 6 hours and likely results in timeout. The second invocation should be faster (I hope). |
|
/test windows,cuda130 |
|
(I forgot to do /test windows,cuda130 |
|
(Confirmed that kernel cache started to appear in the GCS bucket.) |
|
/test windows,cuda130 |
2 similar comments
|
/test windows,cuda130 |
|
/test windows,cuda130 |
|
This looks effective. In the fourth run (i.e. cache is fully populated in previous runs), the build + unit test run completed in 2h13m. |
abeacb7 to
c501c24
Compare
|
/test windows,cuda130 |
|
The CI failure should be fixed by the latest cuda-pathfinder (v1.4.0) /test windows,cuda130 |
|
There are 4 test failures. I'll check tomorrow if we should just skip the tests when the GCP backend is in use (because we'd never be able to change the cache dir locally with |
|
Maybe we can implement NullCacheBackend and activate it in the context manager instead of mocking local cache directory. |
|
I think A |
|
/test windows,cuda130 |
leofang
left a comment
There was a problem hiding this comment.
Thanks, @kmaehashi! Looks like it's working now! I left a question but it is not blocking.
| # DownloadCache "${cache_pr_gcs_dir}" "${cache_archive}" | ||
| #} | ||
|
|
||
| $Env:CUPY_CI_ENABLE_GCP_KERNEL_CACHE = "1" |
There was a problem hiding this comment.
Since the old cache is now working (after #9728), I wonder if we should set this to 1 randomly (with 50-50 chance) so that we get both the old cache (which is exclusively used on the user land) and the new cache (only used in the CI) tested with equal chance.
There was a problem hiding this comment.
set this to 1 randomly
This will double test runs needed to fully populate kernel cache. Even with GCP cache, we have to wait for three time for all tests to success. #9738 (comment)
There was a problem hiding this comment.
My feeling is to look into adding some tests if we are worried, rather than keeping two cache mechanism in CI.
There was a problem hiding this comment.
Sounds good. Let's track this in an issue to follow up. No need to block on the merge.
CI: Use GCP-backed kernel cache in Windows CI
Part of #9665. Based on #9737, this PR introduces GCP-backed kernel cache to Windows CI, which will be activated if
CUPY_CI_ENABLE_GCP_KERNEL_CACHE=1env var is set when invoking pytest.Disclosure: The initial implementation was done by Copilot in kmaehashi#84.
Observations: