BUG: Fix typo in advise and prefetch affecting cuda 13#9493
Merged
Conversation
The struct is already the location, so this added one level. Strangely, Cython chooses to not fail compilation but rather raise a runtime error (pretending that this is a dict). Added a very simple test, but happy to iterate on it if it doesn't seem ideal. Just as a note: this API is documented as experimental.
seberg
changed the title
Member
|
/test mini |
Member
Author
|
Oops, the way these enum levels are defined means that they need an explicit cast (as in some other places here). /test mini |
Member
Author
|
Hmmm, is this something obvious? The call should be using |
Member
|
I'm unsure but it seems managed memory have some limitations on Windows? |
Member
|
This reproduced on my local Windows machine, so it's not CI specific. >>> import cupy
>>> from cupy.cuda import memory, stream as stream_module
>>> mem = memory.malloc_managed(1024)
>>> mem.mem.prefetch(stream_module.get_current_stream())
devPtr=8637120512 count=1024 dstDevice=0 stream=0
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
mem.mem.prefetch(stream_module.get_current_stream())
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "cupy/cuda/memory.pyx", line 256, in cupy.cuda.memory.ManagedMemory.prefetch
runtime.memPrefetchAsync(self.ptr, self.size, device_id, stream.ptr)
File "cupy_backends/cuda/api/runtime.pyx", line 745, in cupy_backends.cuda.api.runtime.memPrefetchAsync
check_status(status)
File "cupy_backends/cuda/api/runtime.pyx", line 147, in cupy_backends.cuda.api.runtime.check_status
raise CUDARuntimeError(status)
cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorInvalidDevice: invalid device ordinal |
Member
Author
|
ahhh, thanks, that makes sense! Added a |
Member
|
/test mini |
Member
|
On Windows it seems |
Member
Author
|
/test mini 🤦 sorry I put the skip on the wrong test... |
seberg
commented
Nov 27, 2025
Co-authored-by: Sebastian Berg <[email protected]>
Member
|
Confirmed all tests passed for 5845cff /test skip |
kmaehashi
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The struct is already the location, so this added one level. Strangely, Cython chooses to not fail compilation but rather raise a runtime error (pretending that this is a dict).
Added a very simple test, but happy to iterate on it if it doesn't seem ideal.
Just as a note: this API is documented as experimental.