File cache: use os.replace (clarity) and accept PermissionError#9483
Merged
Conversation
This uses `os.replace()` since it is a bit more clear that a within-folder move should be atomic. It also allows `PermissionError` on windows since it is possible that the file was already created by another thread and opened for use and windows will then raise a `PermissionError` when the replace fails. Unfortunately, I am not sure there is a good way to test this. Closes cupygh-9463
Member
|
/test mini |
leofang
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
os.replace()since it is a bit more clear that a within-folder move should be atomic.It also allows
PermissionErroron windows since it is possible that the file was already created by another thread and opened for use and windows will then raise aPermissionErrorwhen the replace fails.Unfortunately, I am not sure there is a good way to test this.
Closes gh-9463