MAINT: Specify texture address precisely#9471
Merged
Merged
Conversation
I tried using `profile=True` and I think I also ran into this once before (not sure due to what). In some cases Cython generates code to expose this to Python and then it fails casting to `int*` when compiling the generated C++ code. Maybe whether it fails compiling is dependent on more things, since it doesn't happen in CI?
leofang
reviewed
Nov 5, 2025
leofang
approved these changes
Nov 5, 2025
Member
|
/test mini |
leofang
added
cat:code-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using
profile=Trueand I think I also ran into this once before (not sure due to what).In some cases Cython generates code to expose this to Python and then it fails casting to
int*when compiling the generated C++ code.Maybe whether it fails compiling is dependent on more things, since it doesn't happen in CI?