Add function bitwise_count#9390
Merged
Merged
Conversation
86 tasks
0xtoward
force-pushed
the
feature-bitwise-count
branch
from
0c80b06 to
1711f64
Compare
…int8. Rewrite test function in cupy style.
0xtoward
force-pushed
the
feature-bitwise-count
branch
from
1711f64 to
95ba01e
Compare
kmaehashi
requested changes
Sep 16, 2025
leofang
reviewed
Sep 16, 2025
Member
|
Could you fix the linter errors? |
leofang
reviewed
Sep 17, 2025
0xtoward
force-pushed
the
feature-bitwise-count
branch
from
625448e to
375059e
Compare
0xtoward
changed the title
Member
|
/test mini |
leofang
reviewed
Sep 18, 2025
0xtoward
force-pushed
the
feature-bitwise-count
branch
from
a367ed0 to
5f220fc
Compare
leofang
reviewed
Sep 26, 2025
| @testing.numpy_cupy_array_equal() | ||
| def test_bitwise_count(self, xp, dtype): | ||
| import numpy as np | ||
| info = np.iinfo(dtype) |
Member
There was a problem hiding this comment.
ditto
Suggested change
| info = np.iinfo(dtype) | |
| info = xp.iinfo(dtype) |
Member
|
/teat mini |
Member
|
/test mini |
Member
|
Could you check the CI failures? I think we need to constrain the NumPy version using |
Contributor
Author
|
/test mini |
Member
|
Sorry, we only allow maintainers to trigger the CI pipelines in this repo 😅 |
Member
|
/test mini |
asi1024
approved these changes
Oct 1, 2025
Member
|
LGTM! Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6078