Skip to content

Remove deprecated modules#9337

Merged
kmaehashi merged 9 commits into
cupy:mainfrom
vyasr:chore/remove_deprecated_modules
Sep 6, 2025
Merged

Remove deprecated modules#9337
kmaehashi merged 9 commits into
cupy:mainfrom
vyasr:chore/remove_deprecated_modules

Conversation

@vyasr
Copy link
Copy Markdown
Contributor

@vyasr vyasr commented Aug 30, 2025

The cusparse, cutensor, and cusolver modules were deprecated in cupy 12 (in cd14be9) almost three years ago and are suitable for removal now. cupy.sparse was deprecated in cupy 8 and is certainly removable now. All of the same functionality is available via cupyx today. I updated the upgrade guide to indicate the simple fix of importing them from cupyx instead. This change contributes to #9324.

@vyasr vyasr marked this pull request as ready for review August 30, 2025 00:02
@kmaehashi kmaehashi added no-compat Disrupts backward compatibility prio:medium cat:code-fix Code refactoring that do not change behavior labels Aug 30, 2025
Copy link
Copy Markdown
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love cleanups! Thanks, Vyas.

@leofang
Copy link
Copy Markdown
Member

leofang commented Sep 3, 2025

/test mini

Comment thread tests/cupy_tests/prof_tests/test_range.py
@leofang
Copy link
Copy Markdown
Member

leofang commented Sep 4, 2025

/test mini

@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Sep 5, 2025

It seems like the windows test terminated mid tests without an obvious failure.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 6, 2025

This pull request is now in conflicts. Could you fix it @vyasr? 🙏

Comment thread docs/source/upgrade.rst Outdated
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! 👍

@kmaehashi
Copy link
Copy Markdown
Member

/test skip

I'll merge after checking ReadTheDocs preview.

@kmaehashi kmaehashi self-assigned this Sep 6, 2025
@kmaehashi kmaehashi added this to the v14.0.0a2 milestone Sep 6, 2025
@kmaehashi kmaehashi merged commit 92c2823 into cupy:main Sep 6, 2025
68 checks passed
@vyasr vyasr deleted the chore/remove_deprecated_modules branch September 6, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:code-fix Code refactoring that do not change behavior no-compat Disrupts backward compatibility prio:medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants