CUDA 11.1 or earlier is no longer supported#9281
Merged
Conversation
kmaehashi
reviewed
Aug 4, 2025
Comment on lines
-49
to
-52
| #if (defined(_MSC_VER) && (__CUDACC_VER_MAJOR__ == 11 && __CUDACC_VER_MINOR__ == 2)) | ||
| #define __builtin_unreachable() __assume(false) | ||
| #endif | ||
|
|
Member
There was a problem hiding this comment.
This is required as we still support CUDA 11.2.
kmaehashi
added
cat:bug
…_MINOR__ == 2)) block added back, needed for CUDA 11.2
Ellecee
changed the title
kmaehashi
approved these changes
Aug 5, 2025
Member
|
/test mini |
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 5, 2025
CUDA 11.1 or earlier is no longer supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for Issue #9074.
Since cupy no longer supports CUDA 11.1 or earlier, the #if checks from cupy/cupyx/scipy/signal/_upfirdn.py and cupy/cupyx/scipy/signal/_upfirdn.py have been removed.