Migrate to pyproject.toml by EarlMilktea · Pull Request #9079 · cupy/cupy

EarlMilktea · 2025-04-03T11:46:14Z

Closes #6986. Related to #7577 .

kmaehashi

Thanks! I've tested locally but it seems incremental compilation is no longer working, even if --no-build-isolation? (edit: this should be now resolved by d0da597)

Co-authored-by: Kenichi Maehashi <[email protected]>

https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

e.g., cupyx/cusolver.cpp, cupyx/scipy/ndimage/_bbox_slices.cpp

kmaehashi · 2025-04-30T09:24:46Z

Thanks @EarlMilktea! I've pushed few minor changes, and now confirmed python -m build --sdist --wheel generates the same archive contents as python setup.py {sdist,bdist_wheel}. Let's move on to the cupy-release-tools fixes!

kmaehashi · 2025-04-30T12:49:54Z

/test mini

… build against various versions

kmaehashi · 2025-05-01T04:27:46Z

/test mini

kmaehashi

Pushed some more fixes. CIs are now green 🎉

kmaehashi · 2025-05-19T09:12:16Z

You will see the conflict when merging main branch onto this PR, but you can resolve it just by running ./.pfnci/generate.py. -> done
Once after Limit Cython version to 3.0 or 3.1 #9133 get merged, please adopt the same fix in this PR as well. -> I will do this in Limit Cython version to 3.0 or 3.1 #9133.

kmaehashi · 2025-05-21T01:37:39Z

/test mini

kmaehashi · 2025-05-21T07:02:56Z

Test failures are unrelated. Merging!

chainer-ci · 2025-05-21T07:03:25Z

@kmaehashi Failed to backport automatically.

Not cleanly cherry-picked

Migrate to pyproject.toml

EarlMilktea added 5 commits April 3, 2025 18:39

⚡ Turn on cython cache

e67b9e4

🚧 Migrate to pyproject

4b711cb

🐛 Drop non-file entries

f48469e

🔧 Move lisence info to pyproject

2a18c40

🔧 Remove setup.cfg

a996bc7

EarlMilktea force-pushed the migrate-pyproject-ss branch from 1ff7649 to a996bc7 Compare April 3, 2025 12:15

EarlMilktea added 2 commits April 3, 2025 21:17

🔧 Remove coveragerc

bb80655

🔧 Remove ruff.toml

25a12a0

kmaehashi self-assigned this Apr 4, 2025

kmaehashi added cat:enhancement Improvements to existing features prio:high to-be-backported Pull-requests to be backported to stable branch labels Apr 4, 2025

EarlMilktea added 5 commits April 4, 2025 16:49

💚 Fix config path

f5dc697

💚 Use no-build-isolation CI build

aba5992

📝 Update contribution guide

2392612

🔧 Make ruff infer python version

a29b0cb

Merge branch 'cupy:main' into migrate-pyproject-ss

ce72d56

EarlMilktea marked this pull request as ready for review April 4, 2025 08:31

kmaehashi requested changes Apr 8, 2025

View reviewed changes

Comment thread .pfnci/linux/tests/actions/build.sh

Comment thread install/cupy_builder/cupy_setup_build.py Outdated

Comment thread pyproject.toml Outdated

EarlMilktea and others added 10 commits April 9, 2025 02:53

🔧 Update pyproject.toml

e543233

Co-authored-by: Kenichi Maehashi <[email protected]>

💡 Update .pfnci/linux/tests/actions/build.sh

a9633b7

Co-authored-by: Kenichi Maehashi <[email protected]>

migrate to new license notation to avoid warning

b2304cf

https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

fix style and add comment

7a7869e

skip extensions configuration for dist_info

06d9855

⏪ Turn off cython cache

aec1bcd

💡 Comment on broken cache

52b3708

📝 Comment on --no-build-isolation

ff3bb80

🔀 Merge branch 'main' into migrate-pyproject-ss

6328379

🔧 Fix packages.find

62f55f9

kmaehashi reviewed Apr 11, 2025

View reviewed changes

Comment thread pyproject.toml Outdated

kmaehashi added 2 commits April 30, 2025 08:38

gitignore dist-info

cdcd80e

avoid including cpp under cupyx

1215f4d

e.g., cupyx/cusolver.cpp, cupyx/scipy/ndimage/_bbox_slices.cpp

kmaehashi previously approved these changes Apr 30, 2025

View reviewed changes

kmaehashi added 3 commits May 1, 2025 04:22

install fastrlock

87d8a64

regenerate

cbc768b

install test dependencies outside of build isolation to allow testing…

3127ca9

… build against various versions

kmaehashi dismissed their stale review via 3127ca9 May 1, 2025 04:27

kmaehashi previously approved these changes May 1, 2025

View reviewed changes

EarlMilktea mentioned this pull request May 19, 2025

Pass build options as environment variables (support pyproject.toml migration in CuPy) cupy/cupy-release-tools#414

Merged

Merge remote-tracking branch 'upstream/main' into migrate-pyproject-ss

be255be

kmaehashi dismissed their stale review via be255be May 21, 2025 01:37

kmaehashi merged commit 3b9c58d into cupy:main May 21, 2025
62 of 63 checks passed

kmaehashi added this to the v14.0.0a2 milestone May 21, 2025

EarlMilktea deleted the migrate-pyproject-ss branch May 21, 2025 08:05

kmaehashi mentioned this pull request May 21, 2025

[backport] Migrate to pyproject.toml #9135

Merged

kmaehashi added a commit to kmaehashi/cupy that referenced this pull request May 21, 2025

Merge pull request cupy#9079 from EarlMilktea/migrate-pyproject-ss

e58d2e1

Migrate to pyproject.toml

kmaehashi mentioned this pull request May 21, 2025

Make rebuild faster for development #9136

Merged

kmaehashi added a commit to kmaehashi/cupy that referenced this pull request May 29, 2025

Merge pull request cupy#9079 from EarlMilktea/migrate-pyproject-ss

606bf5c

Migrate to pyproject.toml

kmaehashi mentioned this pull request Jun 26, 2025

[v13] Bump version to v13.5.0 #9212

Merged

This was referenced Jul 4, 2025

Fix long_description missing after pyproject.toml migration #9227

Merged

Do not include files listed in MANIFEST.in to wheels #9230

Merged

kmaehashi mentioned this pull request Aug 15, 2025

[v13] Bump version to v13.6.0 #9314

Merged

gpinkert pushed a commit to ROCm/cupy that referenced this pull request Sep 13, 2025

Merge pull request cupy#9079 from EarlMilktea/migrate-pyproject-ss

9b2f74e

Migrate to pyproject.toml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate to pyproject.toml#9079

Migrate to pyproject.toml#9079
kmaehashi merged 46 commits into
cupy:mainfrom
EarlMilktea:migrate-pyproject-ss

EarlMilktea commented Apr 3, 2025

Uh oh!

kmaehashi left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kmaehashi commented Apr 30, 2025

Uh oh!

kmaehashi commented Apr 30, 2025

Uh oh!

kmaehashi commented May 1, 2025

Uh oh!

kmaehashi left a comment

Uh oh!

kmaehashi commented May 19, 2025 •

edited

Loading

Uh oh!

kmaehashi commented May 21, 2025

Uh oh!

kmaehashi commented May 21, 2025

Uh oh!

Uh oh!

chainer-ci commented May 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

EarlMilktea commented Apr 3, 2025

Uh oh!

kmaehashi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kmaehashi commented Apr 30, 2025

Uh oh!

kmaehashi commented Apr 30, 2025

Uh oh!

kmaehashi commented May 1, 2025

Uh oh!

kmaehashi left a comment

Choose a reason for hiding this comment

Uh oh!

kmaehashi commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmaehashi commented May 21, 2025

Uh oh!

kmaehashi commented May 21, 2025

Uh oh!

Uh oh!

chainer-ci commented May 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kmaehashi left a comment •

edited

Loading

kmaehashi commented May 19, 2025 •

edited

Loading