[ROCm 6.2.2] Conditionally define CUDA_SUCCESS only if it's not#8793
Conversation
kmaehashi
added
cat:enhancement
kmaehashi
reviewed
Dec 9, 2024
To fix the following compilation error when building for AMD GPUs:
```log
In file included from cupy_backends/cuda/libs/cusolver.cpp:847:
In file included from cupy_backends/cuda/libs/../../cupy_lapack.h:12:
In file included from cupy_backends/cuda/libs/../../hip/cupy_rocsolver.h:4:
In file included from cupy_backends/cuda/libs/../../hip/cupy_hip.h:4:
cupy_backends/cuda/libs/../../hip/cupy_hip_common.h:18:16: error: redefinition of 'hipSuccess' as different kind of symbol
18 | const CUresult CUDA_SUCCESS = static_cast<CUresult>(0);
| ^
rocm/6.2.2/include/hip/amd_detail/amd_hip_runtime.h:111:22: note: expanded from macro 'CUDA_SUCCESS'
111 | #define CUDA_SUCCESS hipSuccess
| ^
rocm/6.2.2/include/hip/hip_runtime_api.h:288:5: note: previous definition is here
288 | hipSuccess = 0, ///< Successful completion.
| ^
```
Signed-off-by: Hollow Man <[email protected]>
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Dec 9, 2024
[ROCm 6.2.2] Conditionally define CUDA_SUCCESS only if it's not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the following compilation error when building for AMD GPUs: