Add notice about cupy.array_api removal#8750
Merged
Conversation
Saransh-cpp
reviewed
Nov 17, 2024
Saransh-cpp
left a comment
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks for adding this in! I am not aware of the features going into CuPy v14, but should this say v2.1? NumPy started supporting Array API 2023.12 from v2.1. Please ignore if v2 is the right version here.
|
|
||
| .. note:: | ||
| ``cupy.array_api`` will be removed in CuPy v14 because its NumPy counterpart ``numpy.array_api`` has been removed. | ||
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2 API. |
There was a problem hiding this comment.
Suggested change
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2 API. | |
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2.1 API. |
|
|
||
| .. note:: | ||
| ``cupy.array_api`` will be removed in CuPy v14 because its NumPy counterpart ``numpy.array_api`` has been removed. | ||
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2 API. |
There was a problem hiding this comment.
Suggested change
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2 API. | |
| The root module ``cupy.*`` is now compatible with the Array API specification as it mirrors the NumPy v2.1 API. |
Member
|
No, supporting array API has been one of the goals of NumPy 2(.0), and it's been delivered |
kmaehashi
added
cat:document
asi1024
approved these changes
Nov 18, 2024
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Nov 18, 2024
Add notice about `cupy.array_api` removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: #8470 (comment).
Closes #8470 and #8747.
cc/ @leofang