Support ROCm 6#8319
Merged
Merged
Conversation
kmaehashi
added
cat:enhancement
Contributor
|
From 05233251a78e86bd269f79272561de22991843a1 Mon Sep 17 00:00:00 2001
From: Yiyang Wu <[email protected]>
Date: Thu, 23 May 2024 20:41:14 +0800
Subject: [PATCH] Add ROCm 6 in runtime_version
---
cupy_backends/cuda/libs/_cnvrtc.pxi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/cupy_backends/cuda/libs/_cnvrtc.pxi b/cupy_backends/cuda/libs/_cnvrtc.pxi
index 9f02b5522..b2b06aa4f 100644
--- a/cupy_backends/cuda/libs/_cnvrtc.pxi
+++ b/cupy_backends/cuda/libs/_cnvrtc.pxi
@@ -139,5 +139,8 @@ cdef SoftLink _get_softlink():
elif runtime_version < 6_00_00000:
# ROCm 5.x
libname = 'libamdhip64.so.5'
+ elif runtime_version < 7_00_00000:
+ # ROCm 6.x
+ libname = 'libamdhip64.so.6'
return SoftLink(libname, prefix, mandatory=True)
--
2.44.0 |
Contributor
|
@littlewu2508 the comment should be |
Contributor
Thanks, I've edited the patch |
Berrysoft
reviewed
May 23, 2024
ROCm 6 introduced various changes on its API. In particular, * Removal of gcnarch from hipDeviceProp_t structure * Renaming of ‘memoryType’ in hipPointerAttribute_t structure to ‘type’ This patch allows cupy to be built on this version.
Contributor
Author
|
Rebase on 13.2.0 |
Merged
ax3l
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Thank you!
I am trying to install cupy on a ROCm 6.1 machine (early access for El Capitan at LLNL) and this patch address the configure and compile errors I encountered. Can this patch be merged? :)
Closed
Member
|
Hi @Azusachan, thank you so much for the contribution, and sorry for keeping you waiting! I have verified the build succeeds with this PR, and of course, happy to merge this one to support ROCm 6.x in CuPy. A roadblock I faced when testing this PR was that I couldn't launch the kernel in my environment with ROCm 6.2. Does anyone ever experienced or resolved this kind of issue? Also cc-ing AMD people: @AdrianAbeyta @pnunna93 @lcskrishna @bmedishe @shbiswas834 |
kmaehashi
reviewed
Sep 17, 2024
kmaehashi
reviewed
Sep 17, 2024
Member
Ok my GPU was too old to run ROCm 6.0... The problem disappeared with gfx908. |
Member
|
/test mini |
kmaehashi
previously approved these changes
Sep 17, 2024
This was
linked to
issues
Sep 17, 2024
Member
|
/test mini |
kmaehashi
approved these changes
Sep 18, 2024
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Sep 18, 2024
Support ROCm 6
This was referenced Sep 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCm 6 introduced various changes on its API. In particular,
This patch provides support on ROCm 6.0.0 and above.