Skip to content

Add pyproject.toml#7577

Closed
kmaehashi wants to merge 2 commits into
cupy:mainfrom
kmaehashi:use-pyproject-toml
Closed

Add pyproject.toml#7577
kmaehashi wants to merge 2 commits into
cupy:mainfrom
kmaehashi:use-pyproject-toml

Conversation

@kmaehashi
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi commented May 21, 2023

Closes #6986 and #7870.

After merging this PR, contributors will need to use pip install --no-build-isolation -e . for incremental compilation during development.

Let's merge this one after the release this week.

@kmaehashi kmaehashi changed the title Use pyproject.toml Add pyproject.toml May 21, 2023
@takagi takagi self-assigned this May 22, 2023
@takagi takagi added cat:install Build and installation prio:medium labels May 22, 2023
@kmaehashi kmaehashi changed the title Add pyproject.toml [MERGE PENDING] Add pyproject.toml May 22, 2023
@kmaehashi kmaehashi changed the title [MERGE PENDING] Add pyproject.toml Add pyproject.toml May 26, 2023
@kmaehashi
Copy link
Copy Markdown
Member Author

/test mini

@takagi
Copy link
Copy Markdown
Contributor

takagi commented May 30, 2023

Depending cupy/cupy-release-tools#342 is merged.

@takagi
Copy link
Copy Markdown
Contributor

takagi commented May 30, 2023

/test mini

@kmaehashi
Copy link
Copy Markdown
Member Author

So it seems pip ignores requirements listed in pyproject.toml if --no-build-isolation is specified. (pypa/pip#9314)
I've reverted setup_requires in setup.py.

Depending cupy/cupy-release-tools#342 is merged.

Actually, that one is not depending, but this PR is needed for the cupy-release-tools one :)

/test

@kmaehashi
Copy link
Copy Markdown
Member Author

/test mini

@kmaehashi kmaehashi marked this pull request as draft June 6, 2023 10:07
@kmaehashi kmaehashi added this to the v13 milestone Nov 29, 2023
@kmaehashi
Copy link
Copy Markdown
Member Author

I'd target this one to v13 final.

@takagi takagi removed this from the v13 milestone Jan 31, 2024
@jakirkham
Copy link
Copy Markdown
Member

Should this be retargeted to v14?

@kmaehashi kmaehashi added this to the v14 milestone Apr 3, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 3, 2025

This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏

@kmaehashi
Copy link
Copy Markdown
Member Author

Closing this one as #9079 is going to land. 🚀

@kmaehashi kmaehashi closed this Apr 14, 2025
@kmaehashi kmaehashi modified the milestones: v14, Closed PRs Apr 14, 2025
@kmaehashi kmaehashi deleted the use-pyproject-toml branch May 1, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:install Build and installation prio:medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use pyproject.toml

3 participants