Skip to content

Fix to return correct CUDA version when in CUDA Python mode - #6736

Merged
emcastillo merged 2 commits into
cupy:masterfrom
kmaehashi:fix-cuda-python-runtime-version
Jun 15, 2022
Merged

emcastillo merged 2 commits into
cupy:masterfrom
kmaehashi:fix-cuda-python-runtime-version

Conversation

@kmaehashi

@kmaehashi kmaehashi commented May 23, 2022 •

Copy link
Copy Markdown
Member

This will allow using runtime.runtimeGetVersion() in all locations where branch based on the current CUDA version (to test feature availability) is needed.

leofang
leofang previously approved these changes May 23, 2022
@emcastillo emcastillo self-assigned this May 24, 2022
@emcastillo

Copy link
Copy Markdown
Member

/test mini

@emcastillo emcastillo added cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch labels May 24, 2022
@emcastillo
emcastillo enabled auto-merge May 24, 2022 01:48
@emcastillo emcastillo added this to the v11.0.0b3 milestone May 24, 2022
@kmaehashi kmaehashi added cat:enhancement Improvements to existing features and removed cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch labels May 24, 2022
@kmaehashi

Copy link
Copy Markdown
Member Author

This is primarily needed for #6730 so not backporting to avoid breaking existing behavior.

@kmaehashi kmaehashi added the no-compat Disrupts backward compatibility label May 24, 2022
@emcastillo

Copy link
Copy Markdown
Member

/test mini

@emcastillo

Copy link
Copy Markdown
Member

/test mini

@kmaehashi

Copy link
Copy Markdown
Member Author

Tests passed, could you approve? @emcastillo :)

@emcastillo
emcastillo merged commit 6869b19 into cupy:master Jun 15, 2022
@kmaehashi
kmaehashi deleted the fix-cuda-python-runtime-version branch June 15, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement Improvements to existing features no-compat Disrupts backward compatibility prio:high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants