Add APIs for creating NumPy arrays backed by pinned memory by leofang · Pull Request #4870 · cupy/cupy

leofang · 2021-03-11T06:19:09Z

This PR adds a few convenience functions to the cupyx namespace for allocating NumPy arrays backed by pinned/pagelocked memory, see the discussion around #3625 (comment). Currently the provided APIs are as follows:

cupyx.empty_pinned()
cupyx.empty_like_pinned()
cupyx.zeros_pinned()
cupyx.zeros_like_pinned()

with exactly the semantics as their NumPy counterparts.

Ideally, we can do better than this if we use NumPy's memory hooks to always allocate NumPy arrays from pinned memory (numpy/numpy#17467), however it's still a WIP, so we can only revisit it when it's in.

TODO:

Decide if the name/API is appropriate or not
Add docstrings
Fix order = 'K'
Add tests

TODO: mention it in memory tutorial/reference and else where

leofang · 2021-03-15T17:17:31Z

Help needed: I am writing tests and I noticed @testing.numpy_cupy_array_equal() does not work for this PR, because we are comparing two numpy.ndarrays which breaks the assumption of this test utility. Any advice?

So I wrote a decorator @numpy_cupyx_array_equal() to address this need. The tests added in the new tests/cupyx_tests/test_pinned_array.py largely follows tests/cupy_tests/creation_tests/test_basic.py for the four added functions, with this decorator change and some other necessary but minor changes.

leofang · 2021-03-15T17:19:45Z

Flake8 error will be fixed in #4888.

leofang · 2021-03-15T17:20:24Z

Jenkins, test this please

chainer-ci · 2021-03-15T19:30:01Z

Jenkins CI test (for commit e5f357b, target branch master) failed with status FAILURE.

leofang · 2021-03-15T20:01:14Z

Jenkins, test this please

chainer-ci · 2021-03-15T21:47:38Z

Jenkins CI test (for commit 31d2338, target branch master) succeeded!

cupyx/_pinned_array.py

chainer-ci · 2021-03-23T09:37:02Z

Jenkins CI test (for commit c6804a8, target branch master) succeeded!

leofang · 2021-03-23T12:33:42Z

@kmaehashi Errors are due to OSError: [Errno 28] No space left on device.

kmaehashi · 2021-03-23T13:04:05Z

I've freed up some space now.

pfnCI, test this please.

chainer-ci · 2021-03-23T15:11:28Z

Jenkins CI test (for commit c6804a8, target branch master) succeeded!

leofang · 2021-03-23T15:28:22Z

hmmm...I wonder why Jenkins still shows a red cross despite chainer ci says success?

kmaehashi · 2021-03-24T05:39:20Z

It seems Jenkins github plugin was using deprecated github APIs and now they're removed. I bumped the plugin version so it should work now.

jakirkham · 2021-03-25T19:16:02Z

Jenkins, test this please

chainer-ci · 2021-03-25T21:42:09Z

Jenkins CI test (for commit c6804a8, target branch master) succeeded!

leofang · 2021-03-28T22:54:31Z

Resolved conflicts.

Jenkins, test this please

chainer-ci · 2021-03-28T23:19:06Z

Jenkins CI test (for commit 500d53c, target branch master) failed with status FAILURE.

leofang · 2021-03-29T01:34:11Z

Jenkins, test this please

chainer-ci · 2021-03-29T03:30:52Z

Jenkins CI test (for commit cc6fe6c, target branch master) succeeded!

leofang · 2021-04-02T05:05:41Z

@kmaehashi as mentioned I'd love to have this PR backported 🙏

leofang · 2021-04-19T02:31:01Z

Jenkins, test this please

kmaehashi

LGTM!

chainer-ci · 2021-04-19T04:19:15Z

Jenkins CI test (for commit cc6fe6c, target branch master) succeeded!

Add APIs for creating NumPy arrays backed by pinned memory

leofang · 2021-04-19T06:37:12Z

Thanks, @kmaehashi and @jakirkham!

[WIP] allocate numpy arrays backed by pinned memory

73622b4

leofang mentioned this pull request Mar 11, 2021

Pinned memory allocation returns odd size #3625

Closed

leofang added 2 commits March 14, 2021 17:12

fix APIs; add docstrings

710c6d8

WIP: add to doc index

f992aba

TODO: mention it in memory tutorial/reference and else where

This comment has been minimized.

Sign in to view

more doc

a65c845

kmaehashi self-assigned this Mar 15, 2021

kmaehashi added cat:feature New features/APIs prio:medium labels Mar 15, 2021

leofang added 3 commits March 15, 2021 00:50

[WIP] bug fix; adding tests

295c63d

[WIP] all tests in TestBasic passed

74bdd23

all fixed

0ff023d

leofang changed the title ~~[WIP] Add APIs for creating NumPy arrays backed by pinned memory~~ Add APIs for creating NumPy arrays backed by pinned memory Mar 15, 2021

leofang marked this pull request as ready for review March 15, 2021 17:10

Merge branch 'master' into pinned_arrays

e5f357b

leofang added 2 commits March 15, 2021 14:10

update doc

bcd716c

move doc from cuda.rst to memory.rst

31d2338

leofang added 2 commits March 16, 2021 11:46

Merge branch 'master' into pinned_arrays

1a71105

move _get_strides_for_order_K to cupy.core.internal

ae23d25

leofang commented Mar 16, 2021

View reviewed changes

cupyx/_pinned_array.py Outdated Show resolved Hide resolved

kmaehashi requested changes Mar 17, 2021

View reviewed changes

cupyx/_pinned_array.py Outdated Show resolved Hide resolved

cupyx/_pinned_array.py Outdated Show resolved Hide resolved

cupyx/_pinned_array.py Outdated Show resolved Hide resolved

cupyx/_pinned_array.py Show resolved Hide resolved

leofang added 3 commits March 17, 2021 04:57

move _update_order_char to cupy.core.internal

b833b24

update docstrings

1bc4e3c

update doc

cfa541d

Merge branch 'master' into pinned_arrays

500d53c

leofang added 2 commits March 28, 2021 21:12

Update basic.py

05f188a

Update _pinned_array.py

cc6fe6c

leofang mentioned this pull request Apr 17, 2021

Allocating Numpy Arrays in Pinned Host Memory ut-parla/Parla.py#42

Closed

kmaehashi approved these changes Apr 19, 2021

View reviewed changes

kmaehashi added this to the v10.0.0a1 milestone Apr 19, 2021

kmaehashi added st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch labels Apr 19, 2021

mergify bot merged commit 81431e5 into cupy:master Apr 19, 2021

chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Apr 19, 2021

Merge pull request cupy#4870 from leofang/pinned_arrays

fe98d91

Add APIs for creating NumPy arrays backed by pinned memory

leofang deleted the pinned_arrays branch April 19, 2021 06:36

chainer-ci mentioned this pull request Apr 19, 2021

[backport] Add APIs for creating NumPy arrays backed by pinned memory #5100

Merged

leofang mentioned this pull request Apr 27, 2021

Add a new argument out to cupy.asnumpy() #5155

Merged

kmaehashi mentioned this pull request Aug 11, 2021

Mapped memory functionality (zero-copy) #3452

Closed

Uh oh!

Conversation

leofang commented Mar 11, 2021 • edited by kmaehashi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

leofang commented Mar 15, 2021

Uh oh!

leofang commented Mar 15, 2021

Uh oh!

leofang commented Mar 15, 2021

Uh oh!

chainer-ci commented Mar 15, 2021

Uh oh!

leofang commented Mar 15, 2021

Uh oh!

chainer-ci commented Mar 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chainer-ci commented Mar 23, 2021

Uh oh!

leofang commented Mar 23, 2021

Uh oh!

kmaehashi commented Mar 23, 2021

Uh oh!

chainer-ci commented Mar 23, 2021

Uh oh!

leofang commented Mar 23, 2021

Uh oh!

kmaehashi commented Mar 24, 2021

Uh oh!

jakirkham commented Mar 25, 2021

Uh oh!

chainer-ci commented Mar 25, 2021

Uh oh!

leofang commented Mar 28, 2021

Uh oh!

chainer-ci commented Mar 28, 2021

Uh oh!

leofang commented Mar 29, 2021

Uh oh!

chainer-ci commented Mar 29, 2021

Uh oh!

leofang commented Apr 2, 2021

Uh oh!

leofang commented Apr 19, 2021

Uh oh!

kmaehashi left a comment

Choose a reason for hiding this comment

Uh oh!

chainer-ci commented Apr 19, 2021

Uh oh!

leofang commented Apr 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leofang commented Mar 11, 2021 •

edited by kmaehashi

Loading