Skip to content

Revert "Support batched SVD"#4687

Closed
emcastillo wants to merge 1 commit intomasterfrom
revert-4628-batched_svd
Closed

Revert "Support batched SVD"#4687
emcastillo wants to merge 1 commit intomasterfrom
revert-4628-batched_svd

Conversation

@emcastillo
Copy link
Copy Markdown
Member

Reverts #4628

Lets check CIs if we revert this

@emcastillo
Copy link
Copy Markdown
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) succeeded!

@emcastillo
Copy link
Copy Markdown
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) succeeded!

@emcastillo
Copy link
Copy Markdown
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) succeeded!

@kmaehashi
Copy link
Copy Markdown
Member

pfnCI, test this please.

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 19, 2021

Can I do one little experiment here? I wanna remove skip

@emcastillo
Copy link
Copy Markdown
Member Author

Release is next week, and there is national holiday next tuesday, so we think it might be better to merge this pr first and address the concerns in a new one 😁

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 19, 2021

Right, nvm. The changes I wanna test cannot be done in the revert PR. Let's get this in asap and I'll try them in another PR.

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 19, 2021

Connection failure in a few CIs. Restarting...

Jenkins, test this please

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 19, 2021

Is the CI dead? Progress got aborted...

Jenkins, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) failed with status FAILURE.

1 similar comment
@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) failed with status FAILURE.

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 19, 2021

Looks like simple timeouts.

Jenkins, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) succeeded!

@emcastillo
Copy link
Copy Markdown
Member Author

Jenkins, test this please

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 20, 2021

Looks like the CI is not accepting jobs?

@leofang
Copy link
Copy Markdown
Member

leofang commented Feb 20, 2021

btw it'd be great if the SVD fix #4690 could be tested on daily shuffle.

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit ea7845d, target branch master) succeeded!

@emcastillo
Copy link
Copy Markdown
Member Author

Let's favour #4690 over this

@mergify mergify bot closed this in #4690 Feb 22, 2021
@kmaehashi kmaehashi deleted the revert-4628-batched_svd branch February 22, 2021 13:51
@asi1024 asi1024 added this to the Closed PRs milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants