Merged
Conversation
kmaehashi
added
cat:feature
Member
Author
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit 902c11d, target branch master) succeeded! |
toslunar
requested changes
Feb 24, 2021
Co-authored-by: Toshiki Kataoka <[email protected]>
Member
Author
|
Thanks, @toslunar! Your suggestions make it much cleaner 👍 |
Member
Author
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit da610ee, target branch master) succeeded! |
toslunar
approved these changes
Mar 1, 2021
Member
Author
|
Thanks, @toslunar! |
This was referenced Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #4684 as batched SVD is required but currently emitting random errors in the CI.Close #3062.
pinv: the original implementation already followed NumPy's, so really it's just addingnewaxishere and there to broadcast.