Skip to content

Support cusolverDn<t>gesvdjBatched#3247

Merged
mergify[bot] merged 7 commits intocupy:masterfrom
toslunar:gesvdj-batched
Apr 13, 2020
Merged

Support cusolverDn<t>gesvdjBatched#3247
mergify[bot] merged 7 commits intocupy:masterfrom
toslunar:gesvdj-batched

Conversation

@toslunar
Copy link
Copy Markdown
Member

@toslunar toslunar commented Apr 1, 2020

Rework of #2337 on #3192

  • The second commit is optional.
  • The third commit can be done in a separate PR.

@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 7, 2020

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit e623a5f:

@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 7, 2020

Would you add stubs for cusolverDn<t>gesvdjBatched in cupy_cusolver.h?

@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 7, 2020

As the existing functions use intptr_t to take pointers, how about following that as opposed to size_t ?

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit e623a5f, target branch master) failed with status FAILURE.

@takagi takagi added the cat:feature New features/APIs label Apr 7, 2020
@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 9, 2020

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 7fdd831:

@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 9, 2020

It is supposed that the stubs in cupy_cusolver.h need to be added in #else // #if !defined(CUPY_NO_CUDA) && !defined(CUPY_USE_HIP) branch as well to pass Travis and for Read the Docs?

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 7fdd831, target branch master) succeeded!

@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 13, 2020

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit c1388fe:

@takagi takagi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Apr 13, 2020
@takagi
Copy link
Copy Markdown
Contributor

takagi commented Apr 13, 2020

LGTM! It will be merged after CI will pass.

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit c1388fe, target branch master) succeeded!

@mergify mergify bot merged commit 49fc353 into cupy:master Apr 13, 2020
@toslunar toslunar deleted the gesvdj-batched branch April 13, 2020 08:16
@emcastillo emcastillo added this to the v8.0.0b2 milestone Apr 22, 2020
@takagi takagi mentioned this pull request May 19, 2020
@leofang leofang mentioned this pull request Feb 5, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:feature New features/APIs st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants